I like this KIP. Can you also link to https://issues.apache.org/jira/browse/KAFKA-6126 in the KIP?
What I am wondering though: if we start to partially (ie, step by step) replace the existing StreamsKafkaClient with Java AdminClient, don't we need more KIPs? For example, if we use purge-api for internal topics, it seems like a change that requires a KIP. Similar for passing configs -- the old client might have different config than the old client? Can we double check this? Thus, it might make sense to replace the old client with the new one in one shot. -Matthias On 11/4/17 4:01 AM, Ted Yu wrote: > Looks good overall. > > bq. the creation within StreamsPartitionAssignor > > Typo above: should be StreamPartitionAssignor > > On Fri, Nov 3, 2017 at 4:49 PM, Guozhang Wang <wangg...@gmail.com> wrote: > >> Hello folks, >> >> I have filed a new KIP on adding AdminClient into Streams for internal >> topic management. >> >> Looking for feedback on >> >> *https://cwiki.apache.org/confluence/display/KAFKA/KIP- >> 220%3A+Add+AdminClient+into+Kafka+Streams%27+ClientSupplier >> <https://cwiki.apache.org/confluence/display/KAFKA/KIP- >> 220%3A+Add+AdminClient+into+Kafka+Streams%27+ClientSupplier>* >> >> -- >> -- Guozhang >> >
signature.asc
Description: OpenPGP digital signature
