Thanks, Guozhang. FWIW here's my (non-binding) +1. Sorry for the delay, Gmail decided to mark this thread as spam :roll-eyes:.
-Michael On Tue, Sep 5, 2017 at 10:36 PM, Guozhang Wang <wangg...@gmail.com> wrote: > Thanks for your inputs. The main motivation is indeed to achieve > consistency as we use "wall-clock-time" in some existing classes already, > e.g. > http://kafka.apache.org/0101/javadoc/index.html?org/apache/ > kafka/streams/processor/WallclockTimestampExtractor.html > . > > Since there is no objections I will go ahead and do the renaming now. > > Guozhang > > > On Thu, Aug 31, 2017 at 1:24 AM, Michal Borowiecki < > michal.borowie...@openbet.com> wrote: > > > +0 ambivalent about the naming but do agree that should be kept > consistent > > > > > > > > On 31/08/17 00:43, Matthias J. Sax wrote: > > > >> +1 > >> > >> On 8/30/17 12:00 PM, Bill Bejeck wrote: > >> > >>> +1 > >>> > >>> On Wed, Aug 30, 2017 at 1:06 PM, Damian Guy <damian....@gmail.com> > >>> wrote: > >>> > >>> +1 > >>>> > >>>> On Wed, 30 Aug 2017 at 17:49 Guozhang Wang <wangg...@gmail.com> > wrote: > >>>> > >>>> Hello Michal and community: > >>>>> > >>>>> While working on updating the web docs and java docs for this KIP, I > >>>>> felt > >>>>> that the term SYSTEM_TIME a bit confusing sometimes from a reader's > >>>>> perspective as we are actually talking about wall-clock time. I'd > hence > >>>>> like to propose an minor addendum to this adopted KIP before the > >>>>> release > >>>>> > >>>> to > >>>> > >>>>> rename this enum: > >>>>> > >>>>> SYSTEM_TIME > >>>>> > >>>>> to > >>>>> > >>>>> WALL_CLOCK_TIME > >>>>> > >>>>> > >>>>> For people who have voted on this KIP, could you vote again for this > >>>>> addendum (detailed discussions can be found in this PR: > >>>>> https://github.com/apache/kafka/pull/3732#issuecomment-326043657)? > >>>>> > >>>>> > >>>>> Guozhang > >>>>> > >>>>> > >>>>> > >>>>> > >>>>> On Sat, May 13, 2017 at 8:13 AM, Michal Borowiecki < > >>>>> michal.borowie...@openbet.com> wrote: > >>>>> > >>>>> Thank you all! > >>>>>> > >>>>>> This KIP passed the vote with 3 binding and 5 non-binding +1s: > >>>>>> > >>>>>> +1 (binding) from Guozhang Wang, Ismael Juma and Ewen > Cheslack-Postava > >>>>>> > >>>>>> +1 (non-binding) from Matthias J. Sax, Bill Bejeck, Eno Thereska, > Arun > >>>>>> Mathew and Thomas Becker > >>>>>> > >>>>>> > >>>>>> Created KAFKA-5233 <https://issues.apache.org/ > jira/browse/KAFKA-5233> > >>>>>> created to track implementation. > >>>>>> It's been a fantastic experience for me working with this great > >>>>>> > >>>>> community > >>>> > >>>>> to produce a KIP for the first time. > >>>>>> Big thank you to everyone who contributed! > >>>>>> > >>>>>> Cheers, > >>>>>> Michał > >>>>>> > >>>>>> > >>>>>> On 12/05/17 02:01, Ismael Juma wrote: > >>>>>> > >>>>>> Michal, you have enough votes, would you like to close the vote? > >>>>>> > >>>>>> Ismael > >>>>>> > >>>>>> On Thu, May 11, 2017 at 4:49 PM, Ewen Cheslack-Postava < > >>>>>> > >>>>> e...@confluent.io> <e...@confluent.io> > >>>> > >>>>> wrote: > >>>>>> > >>>>>> > >>>>>> +1 (binding) > >>>>>> > >>>>>> -Ewen > >>>>>> > >>>>>> On Thu, May 11, 2017 at 7:12 AM, Ismael Juma <ism...@juma.me.uk> < > >>>>>> > >>>>> ism...@juma.me.uk> wrote: > >>>> > >>>>> > >>>>>> Thanks for the KIP, Michal. +1(binding) from me. > >>>>>> > >>>>>> Ismael > >>>>>> > >>>>>> On Sat, May 6, 2017 at 6:18 PM, Michal Borowiecki < > >>>>>> > >>>>> michal.borowie...@openbet.com> wrote: > >>>> > >>>>> > >>>>>> Hi all, > >>>>>> > >>>>>> Given I'm not seeing any contentious issues remaining on the > >>>>>> discussion > >>>>>> thread, I'd like to initiate the vote for: > >>>>>> > >>>>>> KIP-138: Change punctuate semantics > >>>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP-138% > >>>>>> 3A+Change+punctuate+semantics > >>>>>> > >>>>>> > >>>>>> Thanks, > >>>>>> Michał > >>>>>> --<http://www.openbet.com/> <http://www.openbet.com/> Michal > >>>>>> Borowiecki > >>>>>> Senior Software Engineer L4 > >>>>>> T: +44 208 742 1600 <+44%2020%208742%201600> <020%208742%201600> > >>>>>> > >>>>>> +44 203 249 8448 <+44%2020%203249%208448> <020%203249%208448> > >>>>>> > >>>>>> > >>>>>> > >>>>>> E: michal.borowie...@openbet.com > >>>>>> W: www.openbet.com > >>>>>> OpenBet Ltd > >>>>>> > >>>>>> Chiswick Park Building 9 > >>>>>> > >>>>>> 566 Chiswick High Rd > >>>>>> > >>>>>> London > >>>>>> > >>>>>> W4 5XT > >>>>>> > >>>>>> UK<https://www.openbet.com/email_promo> <https://www.openbet.com/ > >>>>>> > >>>>> email_promo> > >>>> > >>>>> This message is confidential and intended only for the addressee. If > >>>>>> you > >>>>>> have received this message in error, please immediately notify > >>>>>> > >>>>> thepostmas...@openbet.com and delete it from your system as well as > >>>> any > >>>> > >>>>> copies. The content of e-mails as well as traffic data may be > monitored > >>>>>> > >>>>>> by > >>>>>> > >>>>>> OpenBet for employment and security purposes. To protect the > >>>>>> environment > >>>>>> please do not print this e-mail unless necessary. OpenBet Ltd. > >>>>>> > >>>>>> Registered > >>>>>> > >>>>>> Office: Chiswick Park Building 9, 566 Chiswick High Road, London, W4 > >>>>>> > >>>>>> 5XT, > >>>>>> > >>>>>> United Kingdom. A company registered in England and Wales. > Registered > >>>>>> > >>>>>> no. > >>>>>> > >>>>>> 3134634. VAT no. GB927523612 > >>>>>> > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> <http://www.openbet.com/> Michal Borowiecki > >>>>>> Senior Software Engineer L4 > >>>>>> T: +44 208 742 1600 <+44%2020%208742%201600> > >>>>>> > >>>>>> > >>>>>> +44 203 249 8448 <+44%2020%203249%208448> > >>>>>> > >>>>>> > >>>>>> > >>>>>> E: michal.borowie...@openbet.com > >>>>>> W: www.openbet.com > >>>>>> OpenBet Ltd > >>>>>> > >>>>>> Chiswick Park Building 9 > >>>>>> > >>>>>> 566 Chiswick High Rd > >>>>>> > >>>>>> London > >>>>>> > >>>>>> W4 5XT > >>>>>> > >>>>>> UK > >>>>>> <https://www.openbet.com/email_promo> > >>>>>> This message is confidential and intended only for the addressee. If > >>>>>> you > >>>>>> have received this message in error, please immediately notify the > >>>>>> postmas...@openbet.com and delete it from your system as well as > any > >>>>>> copies. The content of e-mails as well as traffic data may be > >>>>>> monitored > >>>>>> > >>>>> by > >>>> > >>>>> OpenBet for employment and security purposes. To protect the > >>>>>> environment > >>>>>> please do not print this e-mail unless necessary. OpenBet Ltd. > >>>>>> > >>>>> Registered > >>>> > >>>>> Office: Chiswick Park Building 9, 566 Chiswick High Road, London, W4 > >>>>>> > >>>>> 5XT, > >>>> > >>>>> United Kingdom. A company registered in England and Wales. Registered > >>>>>> > >>>>> no. > >>>> > >>>>> 3134634. VAT no. GB927523612 > >>>>>> > >>>>>> > >>>>> > >>>>> -- > >>>>> -- Guozhang > >>>>> > >>>>> > > -- > > Signature > > Michal Borowiecki <http://www.openbet.com/> > > *Senior Software Engineer L4* > > *T:* +44 208 742 1600 <https://signature.openbet/ > cgi-bin/signature.php#> > > > > > > *E:* michal.borowie...@openbet.com < > > https://signature.openbet/cgi-bin/signature.php#> > > *DL: * +44 203 249 8448 <https://signature.openbet/ > cgi-bin/signature.php#> > > > > > > *W:* www.openbet.com <https://signature.openbet/cgi > > -bin/signature.php#> > > ** > > > > > > ** > > > > <https://www.openbet.com/com/email_promo> > > This message is confidential and intended only for the addressee. If you > > have received this message in error, please immediately notify the > > postmas...@openbet.com <mailto:postmas...@openbet.com> and delete it > from > > your system as well as any copies. The content of e-mails as well as > > traffic data may be monitored by OpenBet for employment and security > > purposes. To protect the environment please do not print this e-mail > unless > > necessary. OpenBet Ltd. Registered Office: Chiswick Park Building 9, 566 > > Chiswick High Road, London, W4 5XT, United Kingdom. A company registered > in > > England and Wales. Registered no. 3134634. VAT no. GB927523612 > > > > > > > -- > -- Guozhang >
