Hi, Tom, Thanks for the KIP. +1. Just one more minor comment. It seems that the ElectPreferredLeadersResponse should expect at least 3 other types of errors : (1) request timeout exception, (2) leader rebalance in-progress exception, (3) can't move to the preferred replica exception (i.e., preferred replica not in sync yet).
Jun On Tue, Aug 29, 2017 at 8:56 AM, Tom Bentley <t.j.bent...@gmail.com> wrote: > Hi all, > > I would like to start the vote on KIP-183 which will provide an AdminClient > interface for electing the preferred replica, and refactor the > kafka-preferred-replica-election.sh tool to use this interface. More > details here: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-183+-+Change+ > PreferredReplicaLeaderElectionCommand+to+use+AdminClient > > > Regards, > > Tom >