Hi Damian,
I submit the patch as part of this PR https://github.com/apache/kafka/pull/3611 adding a couple of other tests as well. Maybe you can take a look at it :-) Thanks ! Paolo Patierno Senior Software Engineer (IoT) @ Red Hat Microsoft MVP on Windows Embedded & IoT Microsoft Azure Advisor Twitter : @ppatierno<http://twitter.com/ppatierno> Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno> Blog : DevExperience<http://paolopatierno.wordpress.com/> ________________________________ From: Damian Guy <damian....@gmail.com> Sent: Wednesday, August 2, 2017 5:29 PM To: dev@kafka.apache.org Subject: Re: KStreamPrintTest : no differences in the unit tests Yes - they are basically the same. Feel free to submit a patch to remove one of them On Wed, 2 Aug 2017 at 15:28 Paolo Patierno <ppatie...@live.com> wrote: > Hi devs, > > taking a look at KStreamPrintTest I can't find any substantial difference > between the two tests : > > > testPrintStreamWithProvidedKeyValueMapper > > testPrintKeyValueWithName > > > The only tiny difference is the mapper output "%d, %s" instead of "(%d, > %s)" but then all the code seems to be the same (some other "final" missing > ...). > > Is there something that my eyes can't see ? > > > Thanks, > > > Paolo Patierno > Senior Software Engineer (IoT) @ Red Hat > Microsoft MVP on Windows Embedded & IoT > Microsoft Azure Advisor > > Twitter : @ppatierno<http://twitter.com/ppatierno> > Linkedin : paolopatierno<http://it.linkedin.com/in/paolopatierno> > Blog : DevExperience<http://paolopatierno.wordpress.com/> >
