I think, it might be helpful to add a "admin." prefix, too. For configs for StreamsKafkaClient and later AdminClient.
Can so picky back this on this KIP or should we do a new KIP? -Matthias On 7/10/17 6:45 PM, Guozhang Wang wrote: > Thanks Damian. LGTM. > > Guozhang > > On Mon, Jul 10, 2017 at 1:35 PM, Damian Guy <damian....@gmail.com> wrote: > >> Thanks Guozhang, i added a couple of example usages to the KIP >> >> On Fri, 30 Jun 2017 at 17:06 Guozhang Wang <wangg...@gmail.com> wrote: >> >>> Thanks for the proposal Damian. >>> >>> The PR looks promising to me. One minor comment for the wiki page is that >>> you can add some example on how to call the proposed interface (e.g. the >>> ones you added in unit test in the PR). >>> >>> Another question is that this variable will not be included in the web >> docs >>> in `toHtmlTable` unfortunately, but I do not have a better approach >> either. >>> So maybe we can do no better than manually change the web docs for >>> educating users. >>> >>> >>> Guozhang >>> >>> >>> On Fri, Jun 30, 2017 at 4:18 AM, Damian Guy <damian....@gmail.com> >> wrote: >>> >>>> Hi, >>>> >>>> I've put together what will hopefully be a not too contentious KIP to >>>> enable the setting of default configs for streams internal topics via >>>> StreamsConfig. >>>> >>>> You can find the KIP here: >>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP- >>>> 173%3A+Add+prefix+to+StreamsConfig+to+enable+setting+default+internal+ >>>> topic+configs >>>> There is a PR here: https://github.com/apache/kafka/pull/3459 >>>> >>>> Thanks, >>>> Damian >>>> >>> >>> >>> >>> -- >>> -- Guozhang >>> >> > > >
signature.asc
Description: OpenPGP digital signature
