[
https://issues.apache.org/jira/browse/KAFKA-5394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16039677#comment-16039677
]
ASF GitHub Bot commented on KAFKA-5394:
---------------------------------------
GitHub user cmccabe opened a pull request:
https://github.com/apache/kafka/pull/3250
KAFKA-5394. KafkaAdminClient#timeoutCallsInFlight does not work as ex…
…pected
* Rename KafkaClient#close to KafkaClient#forget to emphasize that it
forgets the requests on a given connection.
* Create KafkaClient#disconnect to tear down a connection and deliver
disconnects to all the requests on it.
* AdminClient.java: fix mismatched braces in JavaDoc.
* Make the AdminClientConfig constructor visible for testing.
* KafkaAdminClient: add TimeoutProcessorFactory to make the
TimeoutProcessor swappable for testing.
* Make TimeoutProcessor a static class rather than an inner class.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cmccabe/kafka KAFKA-5394
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3250.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3250
----
commit fb3905a69bad5e4c37c28c64fdfb2ab786f7b4ed
Author: Colin P. Mccabe <cmcc...@confluent.io>
Date: 2017-06-06T21:19:31Z
KAFKA-5394. KafkaAdminClient#timeoutCallsInFlight does not work as expected
* Rename KafkaClient#close to KafkaClient#forget to emphasize that it
forgets the requests on a given connection.
* Create KafkaClient#disconnect to tear down a connection and deliver
disconnects to all the requests on it.
* AdminClient.java: fix mismatched braces in JavaDoc.
* Make the AdminClientConfig constructor visible for testing.
* KafkaAdminClient: add TimeoutProcessorFactory to make the
TimeoutProcessor swappable for testing.
* Make TimeoutProcessor a static class rather than an inner class.
----
> KafkaAdminClient#timeoutCallsInFlight does not work as expected
> ---------------------------------------------------------------
>
> Key: KAFKA-5394
> URL: https://issues.apache.org/jira/browse/KAFKA-5394
> Project: Kafka
> Issue Type: Bug
> Components: admin
> Reporter: Colin P. McCabe
> Assignee: Colin P. McCabe
>
> {{KafkaAdminClient#timeoutCallsInFlight}} does not work as expected. The
> original idea was that this function would time out a call by closing the
> associated socket. Then the following {{NetworkClient#poll}} call would
> trigger the call to be removed. However, it turns out that it sometimes
> takes time for the {{NetworkClient#poll}} call to return the disconnection
> events. This leads to the call lingering for a while, causing us to
> repeatedly disconnect connections to that node.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
