GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/3233
MINOR: Remove volatile write in RecordHeaders
The JMH benchmark included shows that the redundant
volatile write causes the constructor of `ProducerRecord`
to take more than 50% longer:
ProduceRecordBenchmark.createProducerRecord avgt 15 24.136 ± 1.458
ns/op (before)
ProduceRecordBenchmark.createProducerRecord avgt 15 14.904 ± 0.231
ns/op (after)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
remove-volatile-write-in-records-header-constructor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3233.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3233
----
commit 333b5159b4191a8d958be1664212d54b9b247bd9
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-06-04T14:00:35Z
MINOR: Remove volatile write in RecordHeaders
The JMH benchmark included shows that the redundant
volatile write causes the constructor of `ProducerRecord`
to take more than 50% longer:
ProduceRecordBenchmark.createProducerRecord avgt 15 24.136 ± 1.458
ns/op (before)
ProduceRecordBenchmark.createProducerRecord avgt 15 14.904 ± 0.231
ns/op (after)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
