Thanks for the KIP Bill. With regard to backward compatibility, we should not change the current interface, but add a new interface that extends the current one.
If we are going to add "begin" and "after", we might also consider to add some intermediate call backs. This would allow an application to monitor the restoring progress. We could consider a call back each x records or each x seconds. This callback would not contain a record, but only offset meta data -- like start offset, current offset, end offset. WDYT? -Matthias On 6/1/17 6:17 PM, Bill Bejeck wrote: > Sure thing. I'll update the KIP. > > Thanks, > Bill > > On Thu, Jun 1, 2017 at 6:20 PM, Guozhang Wang <wangg...@gmail.com> wrote: > >> There are also some request to add "begin" and "after" callbacks in the >> restoration func: >> >> https://issues.apache.org/jira/browse/KAFKA-4322 >> >> Could we piggy back them into the same KIP? >> >> >> Guozhang >> >> On Thu, Jun 1, 2017 at 2:04 PM, Bill Bejeck <bbej...@gmail.com> wrote: >> >>> All, >>> >>> I'd like to start the discussion for adding bulk add functionality when >>> restoring a state store. The KIP can be found here: >>> >>> https://cwiki.apache.org/confluence/display/KAFKA/KIP- >>> 167%3A+Add+a+restoreAll+method+to+StateRestoreCallback >>> >>> Thanks, >>> Bill >>> >> >> >> >> -- >> -- Guozhang >> >
signature.asc
Description: OpenPGP digital signature