[ https://issues.apache.org/jira/browse/KAFKA-5031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16026778#comment-16026778 ]
ASF GitHub Bot commented on KAFKA-5031: --------------------------------------- GitHub user gosubpl opened a pull request: https://github.com/apache/kafka/pull/3156 KAFKA-5031: validate count of records for DefaultRecordBatch in validateMessagesAndAssignOffsets https://issues.apache.org/jira/browse/KAFKA-5031 Implements additional check for `DefaultRecordBatch` that compares number of records declared in the header with actual number of records. You can merge this pull request into a Git repository by running: $ git pull https://github.com/gosubpl/kafka KAFKA-5031 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3156.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3156 ---- commit 9a14e56846d26471042e0fcab701fecf5f2fccd7 Author: gosubpl <git...@gosub.pl> Date: 2017-05-26T20:12:29Z KAFKA-5031: validate count of records for DefaultRecordBatch in validateMessagesAndAssignOffsets ---- > Additional validation in validateMessagesAndAssignOffsets > --------------------------------------------------------- > > Key: KAFKA-5031 > URL: https://issues.apache.org/jira/browse/KAFKA-5031 > Project: Kafka > Issue Type: Sub-task > Components: clients, core, producer > Reporter: Ismael Juma > Labels: exactly-once > Fix For: 0.11.0.0 > > > In validateMessagesAndAssignOffsets(), when validating the > DefaultRecordBatch, we should also validate: > 1. Message count matches the actual number of messages in the array > 2. The header count matches the actual number of headers -- This message was sent by Atlassian JIRA (v6.3.15#6346)