[ 
https://issues.apache.org/jira/browse/KAFKA-5225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020221#comment-16020221
 ] 

ASF GitHub Bot commented on KAFKA-5225:
---------------------------------------

GitHub user bharatviswa504 opened a pull request:

    https://github.com/apache/kafka/pull/3117

    KAFKA-5225:StreamsResetter doesn't allow custom Consumer properties

    Added command-config option, as the client configuration is required for 
AdminClient and Embedded Consumer.
    
    @mjsax @guozhangwang please review the changes.
    
    @msjax from previous PR couple of questions.
    1. Tests for Secure cluster, do you mean to add Integration Test?
    2. --dry-run option should print user configs or not? This is just a 
thought. (Not got what do you mean here?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bharatviswa504/kafka KAFKA-5225

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/3117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3117
    
----
commit 3c6bc850ad9d0a5c3118965f7996e2f3dc7171dd
Author: Bharat Viswanadham <bhar...@us.ibm.com>
Date:   2017-05-22T21:12:24Z

    KAFKA-5225:StreamsResetter doesn't allow custom Consumer properties

----


> StreamsResetter doesn't allow custom Consumer properties
> --------------------------------------------------------
>
>                 Key: KAFKA-5225
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5225
>             Project: Kafka
>          Issue Type: Bug
>          Components: streams, tools
>    Affects Versions: 0.10.2.1
>            Reporter: Dustin Cote
>            Assignee: Bharat Viswanadham
>              Labels: needs-kip
>
> The StreamsResetter doesn't let the user pass in any configurations to the 
> embedded consumer. This is a problem in secured environments because you 
> can't configure the embedded consumer to talk to the cluster. The tool should 
> take an approach similar to `kafka.admin.ConsumerGroupCommand` which allows a 
> config file to be passed in the command line for such operations.
> cc [~mjsax]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to