[
https://issues.apache.org/jira/browse/KAFKA-5275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16020039#comment-16020039
]
Colin P. McCabe commented on KAFKA-5275:
----------------------------------------
bq. [~xvl] wrote: To echo Randall's point about having a topic config builder,
I completely agree. However, we should also define constants for every topic
configuration option that exists. Currently the only way to get those is to
pull in the kafka-server jar and access things like LogConfig.SegmentMsProp()
directly
That's a very good point. It would be much more user-friendly to provide
constants. We need this anyway for things like {{alterConfigs}} and
{{describeConfigs}}.
Maybe we could do this by putting all the constants into {{AdminClientConf}}.
Since the server jars depend on the client jars, but not vice versa, we would
then have to change {{KafkaConfig.scala}} so that it defined all these
constants in terms of the {{AdminClientConf}} versions. That way, everything
would stay in sync.
bq. [~rhauch] wrote: Kafka Connect does log which topics were created and which
were found. That'd be trivial if CreateTopicResults had methods to return the
names of the newly-created and existing topics – perhaps something like:
createdTopicNames, existingTopicNames
Hmm. Methods like these, can't handle the case where there is an error other
than {{TopicExistsException}}. They have to throw an exception, and then you
get no information about any topic other than the one that had the exception.
Can't you just iterate through the map and do per-topic error handling? It
just seems like an easier and cleaner solution, unless there's something I'm
missing.
> Review and potentially tweak AdminClient API for the initial release (KIP-117)
> ------------------------------------------------------------------------------
>
> Key: KAFKA-5275
> URL: https://issues.apache.org/jira/browse/KAFKA-5275
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Ismael Juma
> Assignee: Ismael Juma
> Fix For: 0.11.0.0
>
>
> Once all the pieces are in, we should take a pass and ensure that the APIs
> work well together and that they are consistent.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
