[
https://issues.apache.org/jira/browse/KAFKA-4144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018382#comment-16018382
]
ASF GitHub Bot commented on KAFKA-4144:
---------------------------------------
GitHub user jeyhunkarimov opened a pull request:
https://github.com/apache/kafka/pull/3109
KAFKA-4144: Allow per stream/table timestamp extractor
A follow up RP to fix
[issue](https://github.com/confluentinc/examples/commit/2cd0b87bc8a7eab0e7199fa0079db6417f0e6b63#commitcomment-22200864)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeyhunkarimov/kafka KAFKA-4144-follow-up
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3109.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3109
----
commit a35b23a19358d7c2df421e290e5918a45c9cc617
Author: Jeyhun Karimov <[email protected]>
Date: 2017-05-20T09:26:49Z
Follow up overload needed for globalTable()
----
> Allow per stream/table timestamp extractor
> ------------------------------------------
>
> Key: KAFKA-4144
> URL: https://issues.apache.org/jira/browse/KAFKA-4144
> Project: Kafka
> Issue Type: Improvement
> Components: streams
> Affects Versions: 0.10.0.1
> Reporter: Elias Levy
> Assignee: Jeyhun Karimov
> Labels: api, kip
> Fix For: 0.11.0.0
>
>
> At the moment the timestamp extractor is configured via a {{StreamConfig}}
> value to {{KafkaStreams}}. That means you can only have a single timestamp
> extractor per app, even though you may be joining multiple streams/tables
> that require different timestamp extraction methods.
> You should be able to specify a timestamp extractor via
> {{KStreamBuilder.stream()/table()}}, just like you can specify key and value
> serdes that override the StreamConfig defaults.
> KIP: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=68714788
> Specifying a per-stream extractor should only be possible for sources, but
> not for intermediate topics. For PAPI we cannot enforce this, but for DSL
> {{through()}} should not allow to set a custom extractor by the user. In
> contrast, with regard to KAFKA-4785, is must internally set an extractor that
> returns the record's metadata timestamp in order to overwrite the global
> extractor from {{StreamsConfig}} (ie, set
> {{FailOnInvalidTimestampExtractor}}). This change should be done in
> KAFKA-4785 though.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
