[ 
https://issues.apache.org/jira/browse/KAFKA-5266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16017870#comment-16017870
 ] 

Jason Gustafson commented on KAFKA-5266:
----------------------------------------

[~jeqo] Thanks for explaining the case for 3. I guess that makes sense. Would 
it make sense to give this behavior an explicit option (e.g. 
--current-offsets)? For 4., an easy way to reproduce it is set the offset for a 
non-existing topic partition. You'll get something like this:
{code}
Error: Executing consumer group command failed due to null
{code}

> Follow-up improvements for consumer offset reset tool (KIP-122)
> ---------------------------------------------------------------
>
>                 Key: KAFKA-5266
>                 URL: https://issues.apache.org/jira/browse/KAFKA-5266
>             Project: Kafka
>          Issue Type: Bug
>          Components: tools
>            Reporter: Jason Gustafson
>            Assignee: Jorge Quilcate
>             Fix For: 0.11.0.0
>
>
> 1. We should try to ensure that offsets are in range for the topic partition. 
> We currently only verify this for the shift option.
> 2. If you provide a CSV file, you shouldn't need to specify one of the 
> --all-topics or --topic options.
> 3. We currently support a "reset to current offsets" option if none of the 
> supported reset options are provided. This seems kind of useless. Perhaps we 
> should just enforce that one of the reset options is provided.
> 4. The command fails with an NPE if we cannot find one of the offsets we are 
> trying to reset. It would be better to raise an exception with a friendlier 
> message.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to