[ https://issues.apache.org/jira/browse/KAFKA-5246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011252#comment-16011252 ]
ASF GitHub Bot commented on KAFKA-5246: --------------------------------------- GitHub user datalorax opened a pull request: https://github.com/apache/kafka/pull/3061 KAFKA-5246: Remove backdoor that allows any client to produce to internal topics removing unused `AdminUtils.AdminClientId`, as its a security hole. You can merge this pull request into a Git repository by running: $ git pull https://github.com/datalorax/kafka remove_admin_utils__admin_client_id Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/3061.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3061 ---- commit 8aaaac3b57b4f3fb17012348bf02543b472edde8 Author: Andy Coates <andy.coa...@apple.com> Date: 2017-05-15T20:14:52Z KAFKA-5246: remove unused `AdminUtils.AdminClientId`, as its unused and a security hole. ---- > Remove backdoor that allows any client to produce to internal topics > --------------------------------------------------------------------- > > Key: KAFKA-5246 > URL: https://issues.apache.org/jira/browse/KAFKA-5246 > Project: Kafka > Issue Type: Bug > Components: core > Affects Versions: 0.10.0.0, 0.10.0.1, 0.10.1.0, 0.10.1.1, 0.10.2.0, > 0.10.2.1 > Reporter: Andy Coates > Assignee: Andy Coates > Priority: Minor > > kafka.admim.AdminUtils defines an ‘AdminClientId' val, which looks to be > unused in the code, with the exception of a single use in KafkaAPis.scala in > handleProducerRequest, where is looks to allow any client, using the special > ‘__admin_client' client id, to append to internal topics. > This looks like a security risk to me, as it would allow any client to > produce either rouge offsets or even a record containing something other than > group/offset info. > Can we remove this please? -- This message was sent by Atlassian JIRA (v6.3.15#6346)