GitHub user bharatviswa504 opened a pull request:
https://github.com/apache/kafka/pull/3005
Add option "dry run" to Streams application reset tool
Addressed the below review comment from #PR #2998
I am wondering if it would be better, to "embed" the dry-run into the
actual code and branch on each place. Otherwise, if things get changed, we
could easily introduce bugs (ie, dry run show something different than what the
actual reset code does.
We could introduce methods like mabyeSeekToBeginning() that either does the
seek or only prints to stdout. This would ensure that the main logic is used to
"feed" into dry-run and we don't have code duplication.
WDYT?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bharatviswa504/kafka KAFKA-5166
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/3005.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3005
----
commit a95d29be2e832c140186752911331a1f2966a31c
Author: Bharat Viswanadham <bhar...@us.ibm.com>
Date: 2017-05-08T20:03:31Z
KAFKA-5166: Add option dry run to Streams application reset tool
commit 4cf41a36fac5a0ef23532e99ce4fc93e094d4273
Author: Bharat Viswanadham <bhar...@us.ibm.com>
Date: 2017-05-08T21:00:43Z
Updated to add consumer group in description
commit 9e7e8d7dab3127dfe22985f3b33af6a07596ba79
Author: Bharat Viswanadham <bhar...@us.ibm.com>
Date: 2017-05-09T19:19:20Z
addressed review comment to add dry-run logic with main code
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
