In order to keep the voting thread on KIP-146 open for at least 72 hours, I'm amending my previous message and I'm starting the voting process on KIP-146 now. The discussion on KIP-146 may continue here for as long as the voting process is open.
-Konstantine On Mon, May 8, 2017 at 9:47 AM, Konstantine Karantasis < konstant...@confluent.io> wrote: > Dear all, > > KIP-146 has been updated to incorporate the changes that were suggested > during the discussion so far. You may find the updated version here: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 146+-+Classloading+Isolation+in+Connect > > Since none of the suggestions objected the core of this KIP, and they seem > to have been addressed in this new version, I would suggest to wait until > the end-of-day today - let's say that's 5pm PDT worldwide :) - in case > there are any additional comments. If not, I'd be happy to move forward > with a voting thread that could potentially allow this nice feature to be > included in the 0.11.0.0 Apache Kafka release. > > I appreciate your feedback. Let me know if you agree. > > -Konstantine > > > On Mon, May 8, 2017 at 9:34 AM, Konstantine Karantasis < > konstant...@confluent.io> wrote: > >> Hi Mathieu, >> >> I believe you are referring to the connector property "name". This >> property is a connector config property as opposed to a Connect worker >> config property. Name is specified per connector instance and not per >> connector class. The scope of the KIP discussed here (KIP-146) is referring >> to classloading isolation specifically, and therefore does not seem to be >> the appropriate forum to discuss the proposed change to the REST API. >> >> I imagine KIP-151 would be more appropriate, but again this KIP is >> discussing changes to the REST API for Plugins (meaning classes and jars) >> and not live Connector instances. As I mentioned, "name" is a property of a >> connector instance not a connector plugin property. >> >> I hope this helps. >> -Konstantine >> >> >> >> On Fri, May 5, 2017 at 6:44 AM, Mathieu Fenniak < >> mathieu.fenn...@replicon.com> wrote: >> >>> Hi Konstantine, >>> >>> As KIP-151 >>> <https://cwiki.apache.org/confluence/display/KAFKA/KIP-151+E >>> xpose+Connector+type+in+REST+API> >>> is currently adding the connector class information to the Kafka Connect >>> REST API, it might be a nice small detail to augment this KIP to add the >>> module name to the same API. That would allow a clear audit of where the >>> code is being loaded. :-) >>> >>> Mathieu >>> >>> >>> On Sat, Apr 29, 2017 at 10:16 AM, Konstantine Karantasis < >>> konstant...@confluent.io> wrote: >>> >>> > * Because of KIP number collision, please disregard my previous KIP >>> > announcement and use this thread for discussion instead * >>> > >>> > >>> > Hi everyone, >>> > >>> > we aim to address dependency conflicts in Kafka Connect soon by >>> applying >>> > class loading isolation. >>> > >>> > Feel free to take a look at KIP-146 here: >>> > >>> > *https://cwiki.apache.org/confluence/display/KAFKA/KIP- >>> > 146+-+Classloading+Isolation+in+Connect >>> > <https://cwiki.apache.org/confluence/display/KAFKA/KIP- >>> > 146+-+Classloading+Isolation+in+Connect>* >>> > >>> > which describes minimal required changes to public interfaces and the >>> > general implementation approach. >>> > >>> > This is a much wanted feature for Kafka Connect. Your feedback is >>> highly >>> > appreciated. >>> > >>> > -Konstantine >>> > >>> >> >> >
