GitHub user johnma14 opened a pull request:
https://github.com/apache/kafka/pull/2938
KAFKA-5096: Log invalid user configs and use defaults
Kafka Streams do not allow users to modify some consumer configurations.
If the user modifies this property, currently an exception is thrown.
The following changes were made in this patch:
- Defined a new array 'NON_CONFIGURABLE_CONSUMER_CONFIGS' to hold the names
of the configuration parameters that is not allowed to be modified.
Currently, this
contains just 1 parameter - enable_auto_commit. When the 'exactly once'
feature is implemented ( KAFKA-4923), more parameters can be added to this
array.
- Defined a new method 'checkIfUnexpectedUserSpecifiedConsumerConfig' to
check if user overwrote the values of any of the non configurable
configuration
parameters. If so, then log a warning message and reset the default values
- Updated the javadoc to include the configuration parameters that cannot be
modified by users.
- Updated the corresponding tests in StreamsConfigTest.java to reflect the
changes
made in StreamsConfig.java
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/johnma14/kafka bug/kafka-5096
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2938.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2938
----
commit 1194fab4c3529cb3745548711a39cf9ec8753f04
Author: Mariam John <mari...@us.ibm.com>
Date: 2017-04-28T18:32:54Z
KAFKA-5096: Log invalid user configs and use defaults
Kafka Streams do not allow users to modify some consumer configurations.
Currently, it does not allow modifying the value of 'enable_auto_commit'.
If the user modifies this property, currently an exception is thrown.
The following changes were made in this patch:
- Defined a new array 'NON_CONFIGURABLE_CONSUMER_CONFIGS' to hold the names
of the configuration parameters that is not allowed to be modified
- Defined a new method 'checkIfUnexpectedUserSpecifiedConsumerConfig' to
check if user overwrote the values of any of the non configurable
configuration
parameters. If so, then log a warning message and reset the default values
- Updated the javadoc to include the configuration parameters that cannot be
modified by users.
- Updated the corresponding tests in StreamsConfigTest.java to reflect the
changes
made in StreamsConfig.java
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
