Bc Sent from my iPhone B > On 25-Apr-2017, at 10:21, ASF GitHub Bot (JIRA) <j...@apache.org> wrote: > > This message is eligible for Automatic Cleanup! (j...@apache.org) Add > cleanup rule | More info > > [ > https://issues.apache.org/jira/browse/KAFKA-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15982362#comment-15982362 > ] > > ASF GitHub Bot commented on KAFKA-4379: > --------------------------------------- > > GitHub user guozhangwang opened a pull request: > > https://github.com/apache/kafka/pull/2908 > > KAFKA-4379 Followup: Remove eviction listener from InMemoryLRUCache > > > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/guozhangwang/kafka K4379-remove-listener > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/kafka/pull/2908.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: >
> This closesv #2908 > > ---- > commit 44e1cea3a300b0e05e9574284260b774b852cb4e > Author: Guozhang Wang <wangg...@gmail.com> > Date: 2017-04-25T02:07:23Z > > remove eviction listener > C > commit 6343783ec2ffc907ad2b1d25cd764a6e52acc299 > Author: Guozhang Wang <wangguoz@gmail.comem yz > Date: 2017-04-25T04:50:02Z > > fix unit test > > ---- > > >> Remove caching of dirty and removed keys from StoreChangeLoggerpc >> --------------------------------------------------------------- >> >> Key: KAFKA-4379 >> URL: https://issues.apache.org/jira/browse/KAFKA-4379 >> Project: Kafka >> Issue Type: Improvement >> Components: streams >> Affects Versions: 0.10.1.0 >> Reporter: Damian Guy >> Assignee: Damian Guy >> Priority: Minor >> Fix For: 0.10.1.1, 0.10.2.0 >> >> >> The StoreChangeLogger currently keeps a cache of dirty and removed keys and >> will batch the changelog records such that we don't send a record for each >> update. However, with KIP-63 this is unnecessary as the batching and >> de-duping is done by the caching layer. Further, the StoreChangeLogger >> relies on context.timestamp() which is likely to be incorrect when caching >> is enabled > > > > -- > This message was sent by Atlassian JIRA > (v6.3.15#6346)
