[
https://issues.apache.org/jira/browse/KAFKA-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15983801#comment-15983801
]
ASF GitHub Bot commented on KAFKA-5119:
---------------------------------------
GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/2915
KAFKA-5119: Improve information in assert failure for
testMetricCollectionAfterShutdown
This test is failing consistently in
https://jenkins.confluent.io/job/kafka-trunk/,
but nowhere else. I ran this branch in a clone of that job several times
and this
test didn't fail. I suggest we merge this PR, which improves the test, to
help us
gather more information about the test failure.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka
socket-server-test-metric-collection-after-shutdown
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2915.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2915
----
commit aba3ed482e41db011974a44de72e57bc2e3b1a7d
Author: Ismael Juma <ism...@juma.me.uk>
Date: 2017-04-24T22:12:18Z
MINOR: Improve information in assert failure for
testMetricCollectionAfterShutdown
----
> Transient test failure SocketServerTest.testMetricCollectionAfterShutdown
> -------------------------------------------------------------------------
>
> Key: KAFKA-5119
> URL: https://issues.apache.org/jira/browse/KAFKA-5119
> Project: Kafka
> Issue Type: Bug
> Components: unit tests
> Reporter: Jason Gustafson
>
> From a recent build:
> {code}
> 20:04:15 kafka.network.SocketServerTest > testMetricCollectionAfterShutdown
> FAILED
> 20:04:15 java.lang.AssertionError: expected:<0.0> but
> was:<1.603886948862125>
> 20:04:15 at org.junit.Assert.fail(Assert.java:88)
> 20:04:15 at org.junit.Assert.failNotEquals(Assert.java:834)
> 20:04:15 at org.junit.Assert.assertEquals(Assert.java:553)
> 20:04:15 at org.junit.Assert.assertEquals(Assert.java:683)
> 20:04:15 at
> kafka.network.SocketServerTest.testMetricCollectionAfterShutdown(SocketServerTest.scala:414)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
