[ https://issues.apache.org/jira/browse/KAFKA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15979524#comment-15979524 ]
Guozhang Wang commented on KAFKA-617: ------------------------------------- [~jozi-k] I think it has been named to {{handleListOffsetRequest}} now, updated the description as well. > Refactor KafkaApis.handleOffsetRequest > -------------------------------------- > > Key: KAFKA-617 > URL: https://issues.apache.org/jira/browse/KAFKA-617 > Project: Kafka > Issue Type: Improvement > Reporter: Jay Kreps > > This code path is just really bad. > All the business logic is in LogManager and Log. > Also the implementation is really funky. > LogManager already supports getLog and log allows you to get the segment list > so there shouldn't be any logic except in KafkaApis. -- This message was sent by Atlassian JIRA (v6.3.15#6346)