[ https://issues.apache.org/jira/browse/KAFKA-5082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15973251#comment-15973251 ]
Ewen Cheslack-Postava commented on KAFKA-5082: ---------------------------------------------- [~bharatviswa] Great, glad you're interested! You can read up on the basic KIP process here: https://cwiki.apache.org/confluence/display/KAFKA/Kafka+Improvement+Proposals. There is a template in there that should be easy to follow. In this case, the public API changes would probably be minimal so it'd be an easy update. I think the challenge, however, is that Converter is an interface, so adding to it in a backwards compatible way isn't really possible in Java 7 (I believe Java 8 adds that with default methods but I'd need to double check the Java compatibility docs). If we can come up with a way to expose a ConfigDef from Converters in the same way we have for Connectors (https://github.com/apache/kafka/blob/trunk/connect/api/src/main/java/org/apache/kafka/connect/connector/Connector.java#L141) and Transformations (https://github.com/apache/kafka/blob/trunk/connect/api/src/main/java/org/apache/kafka/connect/transforms/Transformation.java#L41), then we should be able enrich the ConnectorConfig with the Converter's config just like we do with the transformations (https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ConnectorConfig.java#L145 is the key point in the code to look at -- from there you'll be able to see how it gets integrated up to the REST API). > Converter configurations are not listed in validation REST API > -------------------------------------------------------------- > > Key: KAFKA-5082 > URL: https://issues.apache.org/jira/browse/KAFKA-5082 > Project: Kafka > Issue Type: Improvement > Components: KafkaConnect > Affects Versions: 0.10.2.1 > Reporter: Ewen Cheslack-Postava > Assignee: Bharat Viswanadham > Labels: needs-kip > > The config validation REST API lists available configurations for the > connector, and, with the addition of SMTs, the transformations as well. You > are also allowed to override the converters per KIP-75, but the configs for > the converters are not included. Ideally these could be integrated in the > same way the transformation configs are. Note that while adding them to the > REST API could reasonably be considered a bug fix that would not require a > KIP, Converters do not currently expose their configs so we probably need a > (very simple) KIP to add a method to expose them. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
