[
https://issues.apache.org/jira/browse/KAFKA-5049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15969834#comment-15969834
]
ASF GitHub Bot commented on KAFKA-5049:
---------------------------------------
GitHub user anukin opened a pull request:
https://github.com/apache/kafka/pull/2857
KAFKA-5049
This PR is for
https://issues.apache.org/jira/browse/KAFKA-5049?jql=project%20%3D%20KAFKA%20AND%20labels%20%3D%20newbie%20AND%20status%20%3D%20Open
This is for enabling check for chroot for each Zkutils instance.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anukin/kafka KAFKA_5049_zkroot_check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2857.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2857
----
commit 557332b0a4fbb7730334439deed417b0be849a96
Author: anukin <anukin2...@gmail.com>
Date: 2017-04-15T06:55:11Z
made zkpath an instance variable in zkutils
----
> Chroot check should be done for each ZkUtils instance
> -----------------------------------------------------
>
> Key: KAFKA-5049
> URL: https://issues.apache.org/jira/browse/KAFKA-5049
> Project: Kafka
> Issue Type: Bug
> Reporter: Ismael Juma
> Labels: newbie
> Fix For: 0.11.0.0
>
>
> In KAFKA-1994, the check for ZK chroot was moved to ZkPath. However, ZkPath
> is a JVM singleton and we may use multiple ZkClient instances with multiple
> ZooKeeper ensembles in the same JVM (for cluster info, authorizer and
> pluggable code provided by users).
> The right way to do this is to make ZkPath an instance variable in ZkUtils so
> that we do the check once per ZkUtils instance.
> cc [~gwenshap] [~junrao], who reviewed KAFKA-1994, in case I am missing
> something.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
