[ 
https://issues.apache.org/jira/browse/KAFKA-4907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15927265#comment-15927265
 ] 

Jun Rao commented on KAFKA-4907:
--------------------------------

[~becket_qin], I was referring to the following code in KafkaConfig. If 
LogMessageTimestampDifferenceMaxMsProp is not set, we default to the retention 
time even for a compacted topic. Since the retention in a compacted topic is 
infinite, it seems that the default logMessageTimestampDifferenceMaxMs should 
be infinite?

  private def getMessageTimestampDifferenceMaxMs: Long = {
    Option(getLong(KafkaConfig.LogMessageTimestampDifferenceMaxMsProp)) match {
      case Some(value) => value
      case None => getLogRetentionTimeMillis
    }
  }


> compacted topic shouldn't reject messages with old timestamp
> ------------------------------------------------------------
>
>                 Key: KAFKA-4907
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4907
>             Project: Kafka
>          Issue Type: Bug
>    Affects Versions: 0.10.1.0
>            Reporter: Jun Rao
>
> In LogValidator.validateTimestamp(), we check the validity of the timestamp 
> in the message without checking whether the topic is compacted or not. This 
> can cause messages to a compacted topic to be rejected when it shouldn't.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to