[
https://issues.apache.org/jira/browse/KAFKA-4657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15905757#comment-15905757
]
ASF GitHub Bot commented on KAFKA-4657:
---------------------------------------
GitHub user adyach opened a pull request:
https://github.com/apache/kafka/pull/2672
KAFKA-4657: Improve test coverage of CompositeReadOnlyWindowStore
This commmit brings improved test coverage for window store fetch method
and WindowStoreIterator
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/adyach/kafka trunk
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2672.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2672
----
commit 2ef77edcd853e23572b9a0543af2907ef89bd241
Author: Andrey Dyachkov <andrey.dyach...@zalando.de>
Date: 2017-03-10T21:51:12Z
KAFKA-4657: improved test coverage
This commmit brings improved test coverage for window store fetch method
and WindowStoreIterator
----
> Improve test coverage of CompositeReadOnlyWindowStore
> -----------------------------------------------------
>
> Key: KAFKA-4657
> URL: https://issues.apache.org/jira/browse/KAFKA-4657
> Project: Kafka
> Issue Type: Sub-task
> Components: streams
> Reporter: Damian Guy
> Fix For: 0.11.0.0
>
>
> No tests that cover what happens when {{windowStore.fetch(...)}} throw an
> {{InvalidStateStoreException}}, i.e., we should check that we get an
> {{InvalidStateStoreException}} with the modified message.
> There are no tests that cover the {{WindowStoreIterator}} that is returned
> when there are no results. In this case we should at least add tests that
> show the expected behaviour for {{peekNextKey}}, {{hasNext}}, and {{next}}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
