Guozhang, I'm fine w/ adjusting if people want to, but it ends up being more code since we also need to convert SerializationExceptions to DataExceptions and the only thing the toConnectData method even does is specific to Connect (adding the SchemaAndValue).
Gwen -- isn't that an SMT? ExtractField? -Ewen On Wed, Mar 1, 2017 at 1:58 PM, Gwen Shapira <g...@confluent.io> wrote: > Hi Ewen, > > Thanks for the KIP, I think it will be useful :) > > I'm just wondering if we can add support not just for bytes schema, > but also for a struct that contains bytes? I'm thinking of the > scenario of using a connector to grab BLOBs out of a DB - I think you > end up with this structure if you use a JDBC connector and custom > query... > > Maybe even support Maps with generic objects using Java's default > serialization? I'm not sure if this is useful. > > Gwen > > > > On Sat, Feb 25, 2017 at 2:25 PM, Ewen Cheslack-Postava > <e...@confluent.io> wrote: > > Hi all, > > > > I've added a pretty trivial KIP for adding a pass-through Converter for > > Kafka Connect, similar to ByteArraySerializer/Deserializer. > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 128%3A+Add+ByteArrayConverter+for+Kafka+Connect > > > > This wasn't added with the framework originally because the idea was to > > deal with structured data for the most part. However, we've seen a couple > > of use cases arise as the framework got more traction and I think it > makes > > sense to provide this out of the box now so people stop reinventing the > > wheel (and using a different fully-qualified class name) for each > connector > > that needs this functionality. > > > > I imagine this will be a rather uncontroversial addition, so if I don't > see > > any comments in the next day or two I'll just start the vote thread. > > > > -Ewen > > > > -- > Gwen Shapira > Product Manager | Confluent > 650.450.2760 | @gwenshap > Follow us: Twitter | blog >
