Onur Karaman created KAFKA-4757:
-----------------------------------

             Summary: NetworkClient trace level logging regressions
                 Key: KAFKA-4757
                 URL: https://issues.apache.org/jira/browse/KAFKA-4757
             Project: Kafka
          Issue Type: Bug
            Reporter: Onur Karaman


Two issues here:
1. Here's what NetworkClient now shows when processing a disconnection:
{code}
[2017-02-10 10:48:57,052] TRACE Cancelled request 
org.apache.kafka.clients.NetworkClient$InFlightRequest@52f759d7 due to node 0 
being disconnected (org.apache.kafka.clients.NetworkClient)
{code}

The log at one point was useful and actually showed the contents of the 
request. For instance, with FetchRequest, you used to be able to see which 
partitions were requested as well as the offsets and max bytes requested per 
partition.

It looks like InFlightRequest itself doesn't actually hold the request but 
instead currently just holds the RequestHeader. We probably want to make 
InFlightRequest hold the entire request to make the original request show up in 
the logs.

2. Sometimes I see the following log:
{code}
[2017-02-10 10:53:59,015] TRACE Sending {} to node 0. 
(org.apache.kafka.clients.NetworkClient)
{code}
Again not very insightful.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to