+1 (binding) On Thu, Feb 9, 2017 at 7:44 AM, Eno Thereska <eno.there...@gmail.com> wrote:
> +1 > > Thanks > Eno > > On 9 Feb 2017, at 11:04, Damian Guy <damian....@gmail.com> wrote: > > > > +1 > > > > On Thu, 9 Feb 2017 at 10:26 Michael Noll <mich...@confluent.io> wrote: > > > >> +1 (non-binding) > >> > >> And thanks again for suggesting and driving this, Steven! :-) > >> > >> Best, > >> Michael > >> > >> > >> > >> > >> On Thu, Feb 9, 2017 at 6:06 AM, Matthias J. Sax <matth...@confluent.io> > >> wrote: > >> > >>> +1 > >>> > >>> On 2/8/17 4:51 PM, Gwen Shapira wrote: > >>>> +1 (binding) > >>>> > >>>> On Wed, Feb 8, 2017 at 4:45 PM, Steven Schlansker > >>>> <sschlans...@opentable.com> wrote: > >>>>> Hi everyone, > >>>>> > >>>>> Thank you for constructive feedback on KIP-121, > >>> KStream.peek(ForeachAction<K, V>) ; > >>>>> it seems like it is time to call a vote which I hope will pass easily > >> :) > >>>>> > >>>>> https://cwiki.apache.org/confluence/display/KAFKA/KIP- > >>> 121%3A+Add+KStream+peek+method > >>>>> > >>>>> I believe the PR attached is already in good shape to consider > >> merging: > >>>>> > >>>>> https://github.com/apache/kafka/pull/2493 > >>>>> > >>>>> Thanks! > >>>>> Steven > >>>>> > >>>> > >>>> > >>>> > >>> > >>> > >> > > -- -- Guozhang