[
https://issues.apache.org/jira/browse/KAFKA-4716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859331#comment-15859331
]
ASF GitHub Bot commented on KAFKA-4716:
---------------------------------------
GitHub user enothereska opened a pull request:
https://github.com/apache/kafka/pull/2522
KAFKA-4716: Send request to controller [WiP]
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/enothereska/kafka KAFKA-4716-metadata
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2522.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2522
----
commit 2d6cce7a7d9e9426ef53304ada46eada70b344ee
Author: Eno Thereska <e...@confluent.io>
Date: 2017-02-09T10:37:23Z
Send request to controller
----
> Fix logic for re-checking if internal topic is ready
> ----------------------------------------------------
>
> Key: KAFKA-4716
> URL: https://issues.apache.org/jira/browse/KAFKA-4716
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 0.10.2.0
> Reporter: Eno Thereska
> Assignee: Eno Thereska
> Priority: Blocker
> Labels: architecture
> Fix For: 0.10.2.0
>
>
> In InternalTopicManager, we have a hardcoded constant MAX_TOPIC_READY_TRY
> that is set to 5. We shouldn't hardcode the retry time and it should be based
> on a timeout, not on a number of retries.
> There are cases when the code in makeReady tries to create a topic but then
> fails because the controller is currently in transition and we get a warning:
> " Could not create internal topics: Could not create topic: <topic name> due
> to This is not the correct controller for this cluster." The code proceeds to
> retry MAX_TOPIC_READY_TRY times in a tight loop, and eventually fails. We
> should have a retry backoff (perhaps just use retry.backoff.ms) and a timeout
> (perhaps just use request.timeout.ms) instead of a number of retries.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
