Hi all, During PR review a few minor improvements to the KIP were suggested:
1. Rename TopicDetails to RequestMetadata and make it an inner class of the CreateTopicPolicy interface. By using a more generic name, we have more flexibility with regards to additional data we may want to pass to the policy in the future without it looking out of place (e.g. session information). 2. Introduce PolicyViolationException with its own error code instead of reusing InvalidRequestException because the latter's documentation is a bit too specific (it mentions malformed clients requests, for example). 3. Fixed config name to be `create.topic.policy.class.name` to match the name of the interface and the fact that the policy works with a single topic (it was previously `create.topics.policy.class.name`). I updated the KIP page to include these changes: https://cwiki.apache.org/confluence/display/KAFKA/KIP-108%3A+Create+Topic+Policy Hopefully these are uncontroversial, but please let me know if you disagree. Ismael On Wed, Jan 11, 2017 at 11:18 PM, Ismael Juma <ism...@juma.me.uk> wrote: > Thanks to everyone who voted and provided feedback. > > The vote has passed with 4 binding +1s (Joel, Gwen, Neha, Sriram) and 4 > non-binding +1s (Edoardo, Roger, Jon, Apurva). > > I have updated the relevant wiki pages. > > Ismael > > On Tue, Jan 10, 2017 at 1:00 AM, Sriram Subramanian <r...@confluent.io> > wrote: > >> +1 >> >> On Mon, Jan 9, 2017 at 3:29 PM, Apurva Mehta <apu...@confluent.io> wrote: >> >> > (hit send too soon) >> > >> > +1 (non-binding).. that is a very well written KIP! >> > >> > On Mon, Jan 9, 2017 at 3:28 PM, Apurva Mehta <apu...@confluent.io> >> wrote: >> > >> > > +1, that1 >> > > >> > > On Mon, Jan 9, 2017 at 2:47 PM, Neha Narkhede <n...@confluent.io> >> wrote: >> > > >> > >> +1 - thanks Ismael! >> > >> >> > >> On Mon, Jan 9, 2017 at 2:30 PM Gwen Shapira <g...@confluent.io> >> wrote: >> > >> >> > >> > +1 - thanks for the proposal, I think it will be super useful for >> > >> admins. >> > >> > >> > >> > On Sun, Jan 8, 2017 at 6:50 AM, Ismael Juma <ism...@juma.me.uk> >> > wrote: >> > >> > > Hi all, >> > >> > > >> > >> > > As the discussion seems to have settled down, I would like to >> > initiate >> > >> > the >> > >> > > voting process for KIP-108: Create Topic Policy: >> > >> > > >> > >> > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-108 >> > >> > > %3A+Create+Topic+Policy >> > >> > > >> > >> > > The vote will run for a minimum of 72 hours. >> > >> > > >> > >> > > Thanks, >> > >> > > Ismael >> > >> > >> > >> > >> > >> > >> > >> > -- >> > >> > Gwen Shapira >> > >> > Product Manager | Confluent >> > >> > 650.450.2760 <(650)%20450-2760> | @gwenshap >> > >> > Follow us: Twitter | blog >> > >> > >> > >> -- >> > >> Thanks, >> > >> Neha >> > >> >> > > >> > > >> > >> > >
