[
https://issues.apache.org/jira/browse/KAFKA-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15833218#comment-15833218
]
ASF GitHub Bot commented on KAFKA-3835:
---------------------------------------
GitHub user jeyhunkarimov opened a pull request:
https://github.com/apache/kafka/pull/2417
KAFKA-3835: Streams is creating two ProducerRecords for each send via
RecordCollector
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jeyhunkarimov/kafka KAFKA-3835
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2417.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2417
----
commit d803e032e3e91da88332f2f4ce257efb905ec101
Author: Jeyhun Karimov <je.kari...@gmail.com>
Date: 2017-01-22T01:27:11Z
RecordCollector send method arguments changed
----
> Streams is creating two ProducerRecords for each send via RecordCollector
> -------------------------------------------------------------------------
>
> Key: KAFKA-3835
> URL: https://issues.apache.org/jira/browse/KAFKA-3835
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 0.10.0.0
> Reporter: Damian Guy
> Assignee: Jeyhun Karimov
> Priority: Minor
> Labels: newbie
> Fix For: 0.10.3.0
>
>
> The RecordCollector.send(..) method below, currently receives a
> ProducerRecord from its caller and then creates another one to forward on to
> its producer. The creation of 2 ProducerRecords should be removed.
> {code}
> public <K, V> void send(ProducerRecord<K, V> record, Serializer<K>
> keySerializer, Serializer<V> valueSerializer,
> StreamPartitioner<K, V> partitioner)
> {code}
> We could replace the above method with
> {code}
> public <K, V> void send(String topic,
> K key,
> V value,
> Integer partition,
> Long timestamp,
> Serializer<K> keySerializer,
> Serializer<V> valueSerializer,
> StreamPartitioner<K, V> partitioner)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
