That makes sense to me, I'll fold that into the PR and update the KIP if it gets committed in that form.
On Fri, Jan 6, 2017 at 9:44 AM Jason Gustafson <ja...@confluent.io> wrote: > +1 One minor comment: would it make sense to let the `Transformation` > interface extend `o.a.k.c.Configurable` and remove the `init` method? > > On Thu, Jan 5, 2017 at 5:48 PM, Neha Narkhede <n...@confluent.io> wrote: > > > +1 (binding) > > > > On Wed, Jan 4, 2017 at 2:36 PM Shikhar Bhushan <shik...@confluent.io> > > wrote: > > > > > I do plan on introducing a new `connect:transforms` module (which > > > `connect:runtime` will depend on), so they will live in a separate > module > > > in the source tree and output. > > > > > > ( https://github.com/apache/kafka/pull/2299 ) > > > > > > On Wed, Jan 4, 2017 at 2:28 PM Ewen Cheslack-Postava < > e...@confluent.io> > > > wrote: > > > > > > > +1 > > > > > > > > Gwen, re: bundling transformations, would it help at all to isolate > > them > > > to > > > > a separate jar or is the concern purely about maintaining them as > part > > of > > > > Kafka? > > > > > > > > -Ewen > > > > > > > > On Wed, Jan 4, 2017 at 1:31 PM, Sriram Subramanian <r...@confluent.io > > > > > > wrote: > > > > > > > > > +1 > > > > > > > > > > On Wed, Jan 4, 2017 at 1:29 PM, Gwen Shapira <g...@confluent.io> > > > wrote: > > > > > > > > > > > I would have preferred not to bundle transformations, but since > SMT > > > > > > capability is a much needed feature, I'll take it in its current > > > form. > > > > > > > > > > > > +1 > > > > > > > > > > > > On Wed, Jan 4, 2017 at 10:47 AM, Shikhar Bhushan < > > > shik...@confluent.io > > > > > > > > > > > wrote: > > > > > > > Hi all, > > > > > > > > > > > > > > I'd like to start voting on KIP-66: > > > > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > > > > 66%3A+Single+Message+Transforms+for+Kafka+Connect > > > > > > > > > > > > > > Best, > > > > > > > > > > > > > > Shikhar > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Gwen Shapira > > > > > > Product Manager | Confluent > > > > > > 650.450.2760 <(650)%20450-2760> <(650)%20450-2760> > <(650)%20450-2760> | @gwenshap > > > > > > Follow us: Twitter | blog > > > > > > > > > > > > > > > > > > > > -- > > Thanks, > > Neha > > >
