[
https://issues.apache.org/jira/browse/KAFKA-4480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726634#comment-15726634
]
ASF GitHub Bot commented on KAFKA-4480:
---------------------------------------
GitHub user vahidhashemian opened a pull request:
https://github.com/apache/kafka/pull/2218
KAFKA-4480: Report an error in 'kafka-configs' command if the config to be
removed does not exist
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vahidhashemian/kafka KAFKA-4480
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2218.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2218
----
commit 61c7e07fec3792a35fae660566a40b7e53c12fe4
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date: 2016-12-06T20:29:38Z
KAFKA-4480: Report an error in 'kafka-configs' command if the config to be
removed does not exist
----
> kafka-configs will execute the removal of an invalid property and not report
> an error
> -------------------------------------------------------------------------------------
>
> Key: KAFKA-4480
> URL: https://issues.apache.org/jira/browse/KAFKA-4480
> Project: Kafka
> Issue Type: Bug
> Components: config
> Affects Versions: 0.10.0.0
> Environment: CentOS Linux release 7.2.1511 (Core)
> java version "1.8.0_102"
> Reporter: Justin
> Assignee: Vahid Hashemian
>
> Problem:
> kafka-configs will execute the removal of an invalid property and not report
> an error
> Steps to Reproduce:
> 1. Add a config property to a topic:
> kafka-configs --zookeeper localhost:2181 --entity-type topics --entity-name
> test1 --alter --add-config max.message.bytes=128000
> 2. Confirm config is present:
> kafka-topics --zookeeper localhost:2181 --describe --topic test1
> Topic:test1 PartitionCount:1 ReplicationFactor:1
> Configs:max.message.bytes=128000
> Topic: test1 Partition: 0 Leader: 0 Replicas: 0 Isr: 0
> 3. Remove config:
> kafka-configs --zookeeper localhost:2181 --entity-type topics --entity-name
> test1 --alter --delete-config max.message.bytes=128000
> Updated config for topic: "test1".
> 4. Config is still present and no error is thrown:
> kafka-topics --zookeeper localhost:2181 --describe --topic test1
> Topic:test1 PartitionCount:1 ReplicationFactor:1
> Configs:max.message.bytes=128000
> Topic: test1 Partition: 0 Leader: 0 Replicas: 0 Isr: 0
> This is due to the "=128000" in the removal statement.
> Impact:
> 1. We would expect there to be an error statement if an invalid property is
> specified for removal. This can lead to unforeseen consequences in heavily
> automated environments.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
