Hi Gwen, At this level, that's probably right, so sounds good (at an implementor's level, I think it's more subtle).
Ismael On Fri, Dec 2, 2016 at 8:51 PM, Gwen Shapira <g...@confluent.io> wrote: > All replicas are assigned replicas. Calling it AssignedReplicasCount > makes it sound like we have non-assigned replicas that we are also > counting somewhere. > > (Guess who requested the change...) > > On Fri, Dec 2, 2016 at 5:25 AM, Ismael Juma <ism...@juma.me.uk> wrote: > > Hi Xavier, > > > > Can you please share the reasoning for the name change? Good to record > such > > things for posterity. :) > > > > Ismael > > > > On Wed, Nov 30, 2016 at 9:20 PM, Xavier Léauté <xav...@confluent.io> > wrote: > > > >> FYI, Based on internal feedback I renamed AssignedReplicasCount to > simply > >> be called ReplicasCount. > >> > >> On Tue, Nov 29, 2016 at 7:56 PM Neha Narkhede <n...@confluent.io> > wrote: > >> > >> > This seems useful, +1 > >> > > >> > On Tue, Nov 29, 2016 at 5:39 AM Ismael Juma <ism...@juma.me.uk> > wrote: > >> > > >> > > Hi Xavier, > >> > > > >> > > Thanks for the KIP. Sounds good to me. > >> > > > >> > > Ismael > >> > > > >> > > On Tue, Nov 29, 2016 at 12:40 AM, Xavier Léauté < > xav...@confluent.io> > >> > > wrote: > >> > > > >> > > > Hi, > >> > > > > >> > > > I created KIP-96 to propose per partition in-sync / assigned > replica > >> > > > metrics. Should be straightforward, but submitting it for proposal > >> > since > >> > > we > >> > > > require it for metrics changes. > >> > > > > >> > > > Here's the link to the KIP: > >> > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > >> > > > 96+-+Add+per+partition+metrics+for+in-sync+and+ > >> assigned+replica+count > >> > > > > >> > > > Thank you, > >> > > > Xavier > >> > > > > >> > > > >> > -- > >> > Thanks, > >> > Neha > >> > > >> > > > > -- > Gwen Shapira > Product Manager | Confluent > 650.450.2760 | @gwenshap > Follow us: Twitter | blog >
