Hello Ismael, It is good to know that you are willing to review KAFKA-3600 again. As before, we at Cloudera are highly in support of client compatibility, and KAFKA-3600 has always been a building block for that. Now that client compatibility is at forefront again, thanks to Colin, I will be happy to rebase KAFKA-3600 on trunk. However, any comments/ feedback on KAFKA-3600's approach on maintaining api version info for each connected broker is highly welcome.
On Wed, Nov 30, 2016 at 5:47 AM, Ismael Juma <ism...@juma.me.uk> wrote: > Thanks Colin, I think this is a good improvement. > > Ashish, some of the concerns with regards to KAFKA-3600 were related to the > cost versus benefit. Once one adds client compatibility, the benefit is > much higher. I would be happy to review and merge KAFKA-3600 if we think it > serves as a good first step towards client compatibility (if the vote for > this passes). Colin, maybe you can review the PR for KAFKA-3600 and see if > you can build on that? Ashish, it may be worth merging trunk into your > branch and fixing the conflicts. > > Ismael > > On Tue, Nov 29, 2016 at 7:39 PM, Ashish Singh <asi...@cloudera.com> wrote: > > > Hello Colin, > > > > In the KIP you mentioned that currently the client uses supported api > > versions information to check if the server supports its desired > versions. > > Not sure, if that is true. I had put together a PR for KAFKA-3600, to do > > that, but it never went in. Also, I could not find how you plan to > perform > > version check on client side. In KAFKA-3600, I am maintaining api version > > for each live connection, and that made a few folks think it is too big > of > > a change. > > > > On Tue, Nov 29, 2016 at 11:05 AM, Colin McCabe <cmcc...@apache.org> > wrote: > > > > > Sorry, that link should be: > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 97%3A+Improved+Kafka+Client+RPC+Compatibility+Policy > > > > > > > > > > > > On Tue, Nov 29, 2016, at 11:04, Colin McCabe wrote: > > > > Hi all, > > > > > > > > I've been thinking about a KIP to improve the Kafka client's > > > > compatibility policy. If you're interested, please check out: > > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > > > 97%3A+Improved+Kafka+Compatibility+Policy > > > > > > > > cheers, > > > > Colin > > > > > > > > > > > -- > > > > Regards, > > Ashish > > > -- Regards, Ashish
