Very nice KIP!
Couple of comments: 1) Current window API is as follows: > JoinWindows.of(timeDifference).before(timeDifference).after(timeDifference) > TimeWindows.of(size).advanceBy(interval) > UnlimitedWindow.of().startOn(start) To align with this scheme, I think it would be better to use the following API for SessionWindows > SessionWindows.with(inactivityGap) 2) I am wondering, why SessionMerger does need the key? 3) You KIP API for SessionWindows and you PR does not align. There are some getters in you code that are not part of the KIP (not sure how important this is) -Matthias On 11/24/16 7:59 AM, Damian Guy wrote: > Hi all, > > I would like to start the discussion on KIP-94: > > https://cwiki.apache.org/confluence/display/KAFKA/KIP-94+Session+Windows > > Thanks, > Damian >
signature.asc
Description: OpenPGP digital signature
