GitHub user onurkaraman opened a pull request:
https://github.com/apache/kafka/pull/2181
KAFKA-4453: add request prioritization
Today all requests (client requests, broker requests, controller requests)
to a broker are put into the same queue. They all have the same priority. So a
backlog of requests ahead of the controller request will delay the processing
of controller requests. This causes requests infront of the controller request
to get processed based on stale state.
Side effects may include giving clients stale metadata, rejecting
ProduceRequests and FetchRequests, and data loss (for some unofficial
definition of data loss in terms of messages beyond the high watermark).
We'd like to minimize the number of requests processed based on stale
state. With request prioritization, controller requests get processed before
regular queued up requests, so requests can get processed with up-to-date state.
Request prioritization can happen at the network layer with the
RequestChannel. The RequestChannel can categorize the request as regular or
prioritized based on the request id. If the incoming request id matches that of
UpdateMetadataRequest, LeaderAndIsrRequest, and StopReplicaRequest, the request
can get prioritized.
One solution is to simply add a prioritized request queue to supplement the
existing request queue in the RequestChannel and add request
prioritization-aware logic to both the sendRequest and receiveRequest
operations of RequestChannel. sendRequest puts the request into the respective
queue based on whether the request is prioritized or not. receiveRequest can
optimistically check the prioritized request queue and otherwise fallback to
the regular request queue. One subtlety here is whether to do a timed poll on
just the regular request queue or on both the prioritized request queue and
regular request queue sequentially. Only applying the timed poll to the regular
request queue punishes a prioritized request that arrives before a regular
request but moments after the prioritized request check. Applying the timed
poll to both queues sequentially results in a guaranteed latency increase on a
regular request.
An alternative is to replace RequestChannelâs existing request queue with
a prioritization-aware blocking queue. This approach avoids the earlier stated
subtlety by allowing the timed poll to apply to either prioritized or regular
requests in low-throughput scenarios while still allowing queued prioritized
requests to go ahead of queued regular requests.
This patch goes with the latter approach to avoid punishing late arriving
prioritized requests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/onurkaraman/kafka KAFKA-4453
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2181
----
commit e7bff71dce307c3ad5e89f8627c63d546878e39e
Author: Onur Karaman <[email protected]>
Date: 2016-11-28T18:54:35Z
KAFKA-4453: add request prioritization
Today all requests (client requests, broker requests, controller requests)
to a broker are put into the same queue. They all have the same priority. So a
backlog of requests ahead of the controller request will delay the processing
of controller requests. This causes requests infront of the controller request
to get processed based on stale state.
Side effects may include giving clients stale metadata, rejecting
ProduceRequests and FetchRequests, and data loss (for some unofficial
definition of data loss in terms of messages beyond the high watermark).
We'd like to minimize the number of requests processed based on stale
state. With request prioritization, controller requests get processed before
regular queued up requests, so requests can get processed with up-to-date state.
Request prioritization can happen at the network layer with the
RequestChannel. The RequestChannel can categorize the request as regular or
prioritized based on the request id. If the incoming request id matches that of
UpdateMetadataRequest, LeaderAndIsrRequest, and StopReplicaRequest, the request
can get prioritized.
One solution is to simply add a prioritized request queue to supplement the
existing request queue in the RequestChannel and add request
prioritization-aware logic to both the sendRequest and receiveRequest
operations of RequestChannel. sendRequest puts the request into the respective
queue based on whether the request is prioritized or not. receiveRequest can
optimistically check the prioritized request queue and otherwise fallback to
the regular request queue. One subtlety here is whether to do a timed poll on
just the regular request queue or on both the prioritized request queue and
regular request queue sequentially. Only applying the timed poll to the regular
request queue punishes a prioritized request that arrives before a regular
request but moments after the prioritized request check. Applying the timed
poll to both queues sequentially results in a guaranteed latency increase on a
regular request.
An alternative is to replace RequestChannelâs existing request queue with
a prioritization-aware blocking queue. This approach avoids the earlier stated
subtlety by allowing the timed poll to apply to either prioritized or regular
requests in low-throughput scenarios while still allowing queued prioritized
requests to go ahead of queued regular requests.
This patch goes with the latter approach to avoid punishing late arriving
prioritized requests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
