[ https://issues.apache.org/jira/browse/KAFKA-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15699362#comment-15699362 ]
Ismael Juma commented on KAFKA-4450: ------------------------------------ Ok, the one I filed was about including 0.10.0 as a source during upgrades (KAFKA-4165) since 0.10.1 had not been released yet. Looking at the code briefly, we do always include the current version as the target of upgrades, right? So, the main thing missing is that once 0.10.1 was released, we should have added that as a source of upgrades in trunk to avoid breaking that upgrade path in trunk. As KAFKA-4165 shows, we only did the same step in the previous release cycle shortly before we branched, which is not ideal. As you say, it would be good to add an automatic check. Checking Maven is the most reliable method I can think of to detect newly released versions. We should probably update the release process wiki to include a step for adding a released version to the upgrade tests. > Add missing 0.10.1.x upgrade tests and ensure ongoing compatibility checks > -------------------------------------------------------------------------- > > Key: KAFKA-4450 > URL: https://issues.apache.org/jira/browse/KAFKA-4450 > Project: Kafka > Issue Type: Bug > Components: system tests > Affects Versions: 0.10.1.0 > Reporter: Ewen Cheslack-Postava > Priority: Critical > Fix For: 0.11.0.0, 0.10.1.1, 0.10.2.0 > > Original Estimate: 72h > Remaining Estimate: 72h > > We have upgrade system tests, but we neglected to update them for the most > recent released versions (we only have LATEST_0_10_0 but not something from > 0_10_1). > We should probably not only add these versions, but also a) make sure some > TRUNK version is always included since upgrade to trunk would always be > possible to avoid issues for anyone deploying off trunk (we want every commit > to trunk to be solid & compatible) and b) make sure there aren't gaps between > versions annotated on the test vs versions that are officially released > (which may not be easy statically with the decorators, but might be possible > by checking the kafkatest version against previous versions and checking for > gaps?). > Perhaps we need to be able to get the most recent release/snapshot version > from the python code so we can always validate previous versions? Even if > that's possible, is there going to be a reliable way to get all the previous > released versions so we can make sure we have all upgrade tests in place? -- This message was sent by Atlassian JIRA (v6.3.4#6332)