Hi Ismael, OK, I do agree with you. At the moment, our code wraps these three classes since they can't be extended. I recently noticed that two of the three are now non-final in trunk. If all three were made non-final, we would like to extend them,
According to the Java specification: *Changing a class that is declared final to no longer be declared final does not break compatibility with pre-existing binaries.* So it shouldn't break anything. Perhaps that is the reason why KAFKA-4250 was merged (I hadn't even noticed it). It is not critical, so I am ok with it not being in the patch release. On Thu, Nov 24, 2016 at 11:43 AM, Ismael Juma <isma...@gmail.com> wrote: > Hi Rajini, > > I think we should avoid making changes like that in patch releases as it > means that code that compiles with 0.10.1.1 may not compile with 0.10.1.0. > Since we now have frequent time based releases, I think it makes sense for > patch releases to only include bug fixes and test stability fixes. > > About the specific changes that you mention, I didn't see a discussion > about compatibility guarantees that are expected by people who subclass > these classes so I think it was a bit premature to merge the ProducerRecord > and ConsumerRecord final removal change. > > Ismael > > On 24 Nov 2016 10:26 am, "Rajini Sivaram" <rajinisiva...@googlemail.com> > wrote: > > > Can we add KAFKA-4440 and KAFKA-4250 to the the list? They make > > ProducerRecord/ConsumerRecord/RecordMetadata non-final so that they can > be > > extended. The changes have minimal impact on the codebase, but will > really > > help when implementing other producers/consumers. It is not a bug-fix, > but > > if we are going to make the change, it will be good to have it in a > release > > soon. > > > > Thank you, > > > > Rajini > > > > > > On Thu, Nov 24, 2016 at 4:36 AM, Bernard Leach <leac...@bouncycastle.org > > > > wrote: > > > > > Hi Guozhang, > > > > > > I have added KAFKA-4438 to that list as that would enable publishing > the > > > scala 2.12 builds of 0.10.1.1. There are other tasks in order to > > actually > > > publish a 2.12 but merging that change would enable that process. > > There’s > > > a corresponding PR on github that consists of a cherry-pick of the > > > corresponding change from trunk. > > > > > > cheers, > > > bern > > > > > > > On 24 Nov 2016, at 06:58, Guozhang Wang <wangg...@gmail.com> wrote: > > > > > > > > Hi everyone, > > > > > > > > We have resolved 15 JIRAs including a few critical bugs in the 0.10.1 > > > > branch since 0.10.1.0 was released so I'd like to propose to release > > > > 0.10.1.1 soon: > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20% > > > 3D%20KAFKA%20AND%20resolution%20%3D%20Fixed%20AND% > > > 20fixVersion%20%3D%200.10.1.1%20ORDER%20BY%20priority% > > > 20DESC%2C%20key%20DESC > > > > > > > > There are still a few outstanding issues that are not unresolved and > > have > > > > 0.10.1.1 as the target version: > > > > > > > > https://issues.apache.org/jira/issues/?jql=project%20% > > > 3D%20KAFKA%20AND%20resolution%20%3D%20Unresolved%20AND% > > > 20fixVersion%20%3D%200.10.1.1%20ORDER%20BY%20priority% > > > 20DESC%2C%20key%20DESC > > > > > > > > Once we have resolved these issues I will start the release process. > > > > > > > > -- > > > > -- Guozhang > > > > > > > > > > > > -- > > Regards, > > > > Rajini > > > -- Regards, Rajini
