One comment below. On Wed, Nov 16, 2016 at 5:08 PM, Mayuresh Gharat <gharatmayures...@gmail.com > wrote:
> - If we don't bump up the magic byte, on the broker side, the broker > will always have to look at both tombstone bit and the value when do the > compaction. Assuming we do not bump up the magic byte, > imagine the broker sees a message which does not have a tombstone bit > set. The broker does not know when the message was produced (i.e. > whether > the message has been up converted or not), it has to take a further > look at > the value to see if it is null or not in order to determine if it is a > tombstone. The same logic has to be put on the consumer as well because > the > consumer does not know if the message has been up converted or not. > - If we upconvert while appending, this is not the case, right? If I understand you correctly, this is not sufficient because the log may have messages appended before it was upgraded to include KIP-87. Ismael
