[ https://issues.apache.org/jira/browse/KAFKA-4390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15669354#comment-15669354 ]
ASF GitHub Bot commented on KAFKA-4390: --------------------------------------- GitHub user hachikuji opened a pull request: https://github.com/apache/kafka/pull/2140 KAFKA-4390: Replace MessageSet usage with client-side alternatives You can merge this pull request into a Git repository by running: $ git pull https://github.com/hachikuji/kafka KAFKA4390 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/kafka/pull/2140.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2140 ---- commit 22353ad7719c2586e1756c0214187196a3323029 Author: Jason Gustafson <ja...@confluent.io> Date: 2016-10-28T08:24:01Z KAFKA-4390: Replace MessageSet usage with client-side alternatives ---- > Replace MessageSet usage with client-side equivalents > ----------------------------------------------------- > > Key: KAFKA-4390 > URL: https://issues.apache.org/jira/browse/KAFKA-4390 > Project: Kafka > Issue Type: Improvement > Reporter: Jason Gustafson > Assignee: Jason Gustafson > > Currently we have two separate implementations of Kafka's message format and > log structure, one on the client side and one on the server side. Once > KAFKA-2066 is merged, we will only be using the client side objects for > direct serialization/deserialization in the request APIs, but we we still be > using the server-side MessageSet objects everywhere else. Ideally, we can > update this code to use the client objects everywhere so that future message > format changes only need to be made in one place. This would eliminate the > potential for implementation differences and gives us a uniform API for > accessing the low-level log structure. -- This message was sent by Atlassian JIRA (v6.3.4#6332)