I don't have much to say here since I reviewed a draft of this already. But I did want to point out that although it expands the API for Connectors (which I think we should be conservative about), it has the really nice impact that it allows connectors that really care about high throughput to avoid flushing their pipelines since they get better control over the offsets to commit. We already supported this in the framework automatically with source connectors, but this is a nice addition that extends that to sink connectors as well.
-Ewen On Fri, Nov 4, 2016 at 2:16 PM, Shikhar Bhushan <shik...@confluent.io> wrote: > Hi all, > > I created KIP-89 for making a Connect API change that allows for sink > connectors to decouple flush and offset commits. > > > https://cwiki.apache.org/confluence/display/KAFKA/KIP- > 89%3A+Allow+sink+connectors+to+decouple+flush+and+offset+commit > > I'd welcome your input. > > Best, > > Shikhar > -- Thanks, Ewen
