[
https://issues.apache.org/jira/browse/KAFKA-4372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15632788#comment-15632788
]
ASF GitHub Bot commented on KAFKA-4372:
---------------------------------------
GitHub user ogirardot opened a pull request:
https://github.com/apache/kafka/pull/2096
KAFKA-4372: Kafka Connect REST API does not handle DELETE of connector with
slashes in their names
Kafka Connect REST API does not handle in many places connectors with
slashes in their names because it expects PathParams, this PR intends to :
* Reject as bad requests API calls trying to create connectors with slashes
in their names
* Add support for connector with slashes in their names in the DELETE part
of the API to allow users to cleanup their connectors without dropping
everything.
This PR adds as well the Unit Test needed for the creation part and was
tested manually for the DELETE part.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ogirardot/kafka
fix/connectors-with-slashes-cannot-be-deleted
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/2096.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2096
----
commit cfdc2a9e50ae75bcaaa98cebf77b91c3fde963f3
Author: Olivier Girardot <o.girar...@lateral-thoughts.com>
Date: 2016-11-03T13:24:12Z
Fix the delete kafka connectors REST API that did not accept slashes
Even though the rest of the API points accept connector names containing
slashes
commit eb08fbbca95ca9bdafc4058ada563b7d1615a721
Author: Olivier Girardot <o.girar...@lateral-thoughts.com>
Date: 2016-11-03T13:52:30Z
Connectors should no longer have slashes in their names
Added a BadRequestException if someone tries to create one like that
and added unit test to check that
----
> Kafka Connect REST API does not handle DELETE of connector with slashes in
> their names
> --------------------------------------------------------------------------------------
>
> Key: KAFKA-4372
> URL: https://issues.apache.org/jira/browse/KAFKA-4372
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 0.10.0.0, 0.10.0.1
> Reporter: Olivier Girardot
> Assignee: Ewen Cheslack-Postava
>
> Currently there is nothing to prevent someone from registering a Kafka
> Connector with slashes in its name, however it's impossible to DELETE it
> afterwards because the DELETE REST API access point is using a PathParam and
> does not allow slashes.
> A few other API points will have a tough times handling connectors with
> slashes in their names.
> We should allow for slashes in the DELETE API points to allow current setups
> to be cleaned up without having to drop all the other connectors, and not
> allow anymore connectors to be created with slashes in their names.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
