GitHub user iconara opened a pull request:

    https://github.com/apache/kafka/pull/2000

    Make Partitioner a Closeable and close it when closing the producer

    Even though Partitioner has a close method it is not closed when the 
producer is closed. Serializers, interceptors and metrics are all closed, so 
partitioners should be closed to.
    
    Looking at [KAFKA-2091](https://issues.apache.org/jira/browse/KAFKA-2091) 
(d6c45c70fb9773043766446e88370db9709e7995) that introduced the `Partitioner` 
interface it looks like the intention was that the producer should close the 
partitioner.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/iconara/kafka kafka-4284

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/2000.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2000
    
----
commit dcf85e553f69df7a3327166c56e16f3a12694c6c
Author: Theo <t...@iconara.net>
Date:   2016-10-10T11:06:12Z

    Make Partitioner a Closeable and close it when closing the producer
    
    Even though Partitioner has a close method it is not closed when the 
producer is closed. Serializers, interceptors and metrics are all closed, so 
partitioners should be closed to.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to