GitHub user ijuma opened a pull request:
https://github.com/apache/kafka/pull/1985
MINOR: A bunch of clean-ups related to usage of unused variables
There should be only 2 cases where these clean-ups have a functional impact:
1. Fix a bug in the newly introduced `fetchAllChildEntityConfigs` where we
are concatenating
`Some(s)` instead of `s`.
2. Replaced repeated identical logs with a single log for the stale
controller epoch case
The rest should just make the code easier to read and make it a bit less
wasteful. I did this exercise because unused variables sometimes mask bugs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijuma/kafka remove-unused
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1985.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1985
----
commit 36f60b7ed572a357530696fcef36161784e4ab70
Author: Ismael Juma <[email protected]>
Date: 2016-10-07T01:50:05Z
Use `path` instead of `rootPath` when building entity type
commit 30a454590bdd7ff1c8931f579548dc5732bc32df
Author: Ismael Juma <[email protected]>
Date: 2016-10-07T01:55:47Z
Remove unused fields, variables and methods
commit 75e1c4d78c547b44cb32d99fa0efbf11745b144b
Author: Ismael Juma <[email protected]>
Date: 2016-10-07T01:56:19Z
Remove unnecessary initialisation
commit 7ad124832b69f4ca4f9e36ceb4eab53a764ff28a
Author: Ismael Juma <[email protected]>
Date: 2016-10-07T02:02:41Z
Use underscore instead of unused variables
commit 12cf7705f81e286cdfa6c1fbb7fed91a1f69acbc
Author: Ismael Juma <[email protected]>
Date: 2016-10-07T02:03:53Z
Minor exception handling clean-ups
commit d73e47f7ba907280ecc3f8096b3eca1d600bc66a
Author: Ismael Juma <[email protected]>
Date: 2016-10-07T02:08:16Z
Use `keys`, `values` and similar methods to avoid unused variables
commit 43b8709d8b17c5ff60f77f4b33999d11d690dfee
Author: Ismael Juma <[email protected]>
Date: 2016-10-07T02:09:03Z
Avoid unnecessary `toSet` and replace pattern matching by `isDefined`
commit e17d31467b3fbd4a7e9f2e870b37e69e987394d6
Author: Ismael Juma <[email protected]>
Date: 2016-10-07T02:10:24Z
Replace one log entry per partition with a single log entry for a stale
controller epoch error
Since the same information was printed each time, it seems completely
pointless to print it
multiple times.
commit 98324c448daf68e8392a163dfe618f712066ea35
Author: Ismael Juma <[email protected]>
Date: 2016-10-07T02:11:05Z
Controller clean-ups related to unused variables
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
