GitHub user chemikadze opened a pull request:

    https://github.com/apache/kafka/pull/1875

    KAFKA-4190 kafka-reassign-partitions does not report syntax problem in json

    When specifying invalid json file, kafka-reassign-partitions fails with 
error "file is empty" instead of reporting syntax error.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/chemikadze/kafka fb-invalid-json-reporting

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1875.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1875
    
----
commit 29753461f7215ae83846f7eb575a6a9553a444ff
Author: Nikolay Sokolov <chemika...@gmail.com>
Date:   2016-09-18T08:06:00Z

    Fix treating invalid json as empty valid json
    
    Parsing invalid json when executing kafka-reassign-partitions should 
clearly state that json is invalid. Also, when any required keys are missing, 
it is better to state what key is missing.

commit 57c9be879fc9d19649e6401fa8e88e04347cfd35
Author: Nikolay Sokolov <chemika...@gmail.com>
Date:   2016-09-18T08:16:55Z

    Improve error reporting in cases when Json.parseFull returns None

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to