[
https://issues.apache.org/jira/browse/KAFKA-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15474933#comment-15474933
]
ASF GitHub Bot commented on KAFKA-3703:
---------------------------------------
GitHub user rajinisivaram opened a pull request:
https://github.com/apache/kafka/pull/1836
KAFKA-3703: Graceful close for consumers and producer with acks=0
Process requests received from channels before they were closed. For
consumers, wait for coordinator requests to complete before returning from
close.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rajinisivaram/kafka KAFKA-3703
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1836.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1836
----
commit 44ac2327c9c6b66de702fccf0b3c9cabcd8bc25b
Author: Rajini Sivaram <rajinisiva...@googlemail.com>
Date: 2016-09-02T07:55:49Z
KAFKA-3703: Graceful close for consumers and producer with acks=0
----
> Selector.close() doesn't complete outgoing writes
> -------------------------------------------------
>
> Key: KAFKA-3703
> URL: https://issues.apache.org/jira/browse/KAFKA-3703
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Affects Versions: 0.10.0.1
> Reporter: Rajini Sivaram
> Assignee: Rajini Sivaram
>
> Outgoing writes may be discarded when a connection is closed. For instance,
> when running a producer with acks=0, a producer that writes data and closes
> the producer would expect to see all writes to complete if there are no
> errors. But close() simply closes the channel and socket which could result
> in outgoing data being discarded.
> This is also an issue in consumers which use commitAsync to commit offsets.
> Closing the consumer may result in commits being discarded because writes
> have not completed before close().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
