[ 
https://issues.apache.org/jira/browse/KAFKA-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472806#comment-15472806
 ] 

ASF GitHub Bot commented on KAFKA-3144:
---------------------------------------

GitHub user vahidhashemian reopened a pull request:

    https://github.com/apache/kafka/pull/1336

    KAFKA-3144: Report members with no assigned partitions in 
ConsumerGroupCommand

    This PR makes a couple of enhancements to the `--describe` option of 
`ConsumerGroupCommand`:
    1. Listing members with no assigned partitions.
    2. Showing the member id along with the owner of each partition (owner is 
supposed to be the logical application id and all members in the same group are 
supposed to set the same owner).
    3. Reporting broker id of the group coordinator when `--new-consumer` is 
used.
    4. Printing a warning indicating whether ZooKeeper based or new consumer 
API based information is being reported.
    
    It also adds unit tests to verify the added functionality.
    
    Note: The third request on the corresponding JIRA (listing active offsets 
for empty groups of new consumers) is not implemented as part of this PR, and 
has been moved to its own JIRA (KAFKA-3853).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vahidhashemian/kafka KAFKA-3144

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1336.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1336
    
----
commit 5e3550a238fd735081eb88ec564a726c8009f017
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date:   2016-09-07T23:06:00Z

    This PR makes a few enhancements to the --describe option of 
ConsumerGroupCommand:
    1. Listing members with no assigned partitions.
    2. Showing the member id along with the owner of each partition (owner is 
supposed to be the logical application id and all members in the same group are 
supposed to set the same owner).
    3. Reporting broker id of the group coordinator when --new-consumer is used.
    4. Printing a warning indicating whether ZooKeeper based or new consumer 
API based information is being reported.
    
    It also adds unit tests to verify the added functionality.
    
    Note: The third request on the corresponding JIRA (listing active offsets 
for empty groups of new consumers) is not implemented as part of this PR, and 
has been moved to its own JIRA (KAFKA-3853).

----


> report members with no assigned partitions in ConsumerGroupCommand
> ------------------------------------------------------------------
>
>                 Key: KAFKA-3144
>                 URL: https://issues.apache.org/jira/browse/KAFKA-3144
>             Project: Kafka
>          Issue Type: Improvement
>    Affects Versions: 0.9.0.0
>            Reporter: Jun Rao
>            Assignee: Vahid Hashemian
>              Labels: newbie
>
> A couple of suggestions on improving ConsumerGroupCommand. 
> 1. It would be useful to list members with no assigned partitions when doing 
> describe in ConsumerGroupCommand.
> 2. Currently, we show the client.id of each member when doing describe in 
> ConsumerGroupCommand. Since client.id is supposed to be the logical 
> application id, all members in the same group are supposed to set the same 
> client.id. So, it would be clearer if we show the client id as well as the 
> member id.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to