[ 
https://issues.apache.org/jira/browse/KAFKA-4033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15472599#comment-15472599
 ] 

ASF GitHub Bot commented on KAFKA-4033:
---------------------------------------

GitHub user vahidhashemian reopened a pull request:

    https://github.com/apache/kafka/pull/1726

    KAFKA-4033: KIP-70: Revise Partition Assignment Semantics on New Consumer's 
Subscription Change

    This PR changes topic subscription semantics so a change in subscription 
does not immediately cause a rebalance.
    Instead, the next poll or the next scheduled metadata refresh will update 
the assigned partitions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vahidhashemian/kafka KAFKA-4033

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1726
    
----
commit c84ca373a1f9257483273b99119b70cb274c257d
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date:   2016-08-22T18:45:52Z

    KAFKA-4033: KIP-70: Revise Partition Assignment Semantics on New Consumer's 
Subscription Change
    
    This PR changes topic subscription semantics so a change in subscription 
does not immediately cause a rebalance.
    Instead, the next poll or the next scheduled metadata refresh will update 
the assigned partitions.

commit 6533ece037b31ac76e94b736f89485d145c5db15
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date:   2016-08-22T23:29:48Z

    Unit test for subscription change

commit 024ff0ad523cac9178e3006d62e1afc37a997ec3
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date:   2016-08-24T06:22:05Z

    Clean up KafkaConsumerTest.java and add reusable methods

commit ce7e220d98ffd7b336fc0a6c76066150ad1a0ad4
Author: Vahid Hashemian <vahidhashem...@us.ibm.com>
Date:   2016-08-26T00:23:22Z

    Fix unsubscribe semantics and add necessary unit tests

----


> KIP-70: Revise Partition Assignment Semantics on New Consumer's Subscription 
> Change
> -----------------------------------------------------------------------------------
>
>                 Key: KAFKA-4033
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4033
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Vahid Hashemian
>            Assignee: Vahid Hashemian
>
> Modify the new consumer's implementation of topics subscribe and unsubscribe 
> interfaces so that they do not cause an immediate assignment update (this is 
> how the regex subscribe interface is implemented). Instead, the assignment 
> remains valid until it has been revoked in the next rebalance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to