[ 
https://issues.apache.org/jira/browse/KAFKA-4062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446613#comment-15446613
 ] 

ASF GitHub Bot commented on KAFKA-4062:
---------------------------------------

GitHub user cotedm opened a pull request:

    https://github.com/apache/kafka/pull/1797

    KAFKA-4062: Require --print-data-log if --offsets-decoder is enabled for 
DumpLogOffsets

    set print-data-log option when offset-decoder is set.  @hachikuji we had 
talked about this one before, does this change look ok to you?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cotedm/kafka KAFKA-4062

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/kafka/pull/1797.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1797
    
----
commit beb9735c6a3bdcf9bb50a229caf05314fca11ffc
Author: Dustin Cote <dus...@confluent.io>
Date:   2016-08-29T18:09:59Z

    set print-data-log option when offset-decoder is set

----


> Require --print-data-log if --offsets-decoder is enabled for DumpLogOffsets
> ---------------------------------------------------------------------------
>
>                 Key: KAFKA-4062
>                 URL: https://issues.apache.org/jira/browse/KAFKA-4062
>             Project: Kafka
>          Issue Type: Improvement
>          Components: admin
>            Reporter: Dustin Cote
>            Assignee: Dustin Cote
>            Priority: Minor
>
> When using the DumpLogOffsets tool, if you want to print out contents of 
> __consumer_offsets, you would typically use --offsets-decoder as an option.  
> This option doesn't actually do much without --print-data-log enabled, so we 
> should just require it to prevent user errors.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to