GitHub user eliasdorneles opened a pull request:
https://github.com/apache/kafka/pull/1741
Add more verbose logging for offset map building
I propose to make the offset map building a bit more verbose to make log
cleaning messages a bit easier to follow, for people not much familiar with the
code like myself.
Specifically, it's confusing when we get messages like these in the log:
```
[2016-08-15 16:22:42,861] INFO Cleaner 0: Growing cleaner I/O buffers from
65536bytes to 131072 bytes. (kafka.log.LogCleaner)
[2016-08-15 16:22:46,002] INFO Cleaner 0: Growing cleaner I/O buffers from
65536bytes to 131072 bytes. (kafka.log.LogCleaner)
[2016-08-15 16:22:48,844] INFO Cleaner 0: Growing cleaner I/O buffers from
65536bytes to 131072 bytes. (kafka.log.LogCleaner)
```
When stumbling upon this the first time, these looked like a bug (why are
buffers trying to grow into the same sizes, for the same thread?).
Then, after checking the code, I realized these are for different segments.
This PR aims to make that a bit more clear.
Does this look good?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/eliasdorneles/kafka more-verbose-log-cleaning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1741.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1741
----
commit 659bb576a8b0b2d3692e95713c050e78a1401d15
Author: Elias Dorneles <[email protected]>
Date: 2016-08-15T18:01:30Z
add more verbose logging for offset map building
I propose do make the offset map building a bit more verbose to
make log cleaning messages a bit easier to follow, for people
not much familiar with the code like myself.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
